linux-kernel - [PATCH] ACPI / resources: fix memory leak on request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1435609020-18695-1-git-send-email-colin.king@canonical.com>
Date:	Mon, 29 Jun 2015 21:17:00 +0100
From:	Colin King <colin.king@...onical.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] ACPI / resources: fix memory leak on request_range fail path

From: Colin Ian King <colin.king@...onical.com>

static analysis from cppcheck detected a memory leak:
  [drivers/acpi/resource.c:664]: (error) Memory leak: reg

the error path on a failed request_range call should free
reg before returning. Bug introduced in the recent commit
0f1b414d190724617eb1cdd615592fa8cd9d0b50
("ACPI / PNP: Avoid conflicting resource reservations")

Fixes: 0f1b414d19 ("ACPI / PNP: Avoid conflicting resource reservations")
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/acpi/resource.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index fcb7807..10561ce 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -660,8 +660,10 @@ static int add_region_before(u64 start, u64 end, u8 space_id,
 		return -ENOMEM;
 
 	error = request_range(start, end, space_id, flags, desc);
-	if (error)
+	if (error) {
+		kfree(reg);
 		return error;
+	}
 
 	reg->start = start;
 	reg->end = end;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/