linux-kernel - Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACh33Fp4mvk6bwbPPzuuMbZo-GqOkT-hnbOqeVaK-479CReovg@mail.gmail.com>
Date:	Mon, 29 Jun 2015 19:38:12 -0400
From:	Patrick Donnelly <batrick@...bytes.com>
To:	Peter Hurley <peter@...leysoftware.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp

Hi Peter,

On Sun, Jun 28, 2015 at 3:27 PM, Peter Hurley <peter@...leysoftware.com> wrote:
> The label name changing is not really necessary and would reduce diff count.

I've removed the label changes in the next series. Thanks for the feedback.

> It would be nice to get the printk() out from the locks as well (in a follow-on
> patch?)

I don't follow what you're referring to. Is it these lines?

    if (!tty->pgrp) {
        printk(KERN_WARNING "tty_check_change: tty->pgrp == NULL!\n");

-- 
Patrick Donnelly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/