linux-kernel - Re: [PATCH] ALSA: hda: Delete an unnecessary check before the function call "snd_info_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hpp4ega3q.wl-tiwai@suse.de>
Date:	Mon, 29 Jun 2015 11:03:21 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] ALSA: hda: Delete an unnecessary check before the function call "snd_info_free_entry"

At Sun, 28 Jun 2015 11:21:36 +0200,
SF Markus Elfring wrote:
> 
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 28 Jun 2015 11:15:28 +0200
> 
> The snd_info_free_entry() function tests whether its argument is NULL and
> then returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Applied, thanks.


Takashi

> ---
>  sound/pci/hda/patch_hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
> index f852734..2f24338 100644
> --- a/sound/pci/hda/patch_hdmi.c
> +++ b/sound/pci/hda/patch_hdmi.c
> @@ -591,7 +591,7 @@ static int eld_proc_new(struct hdmi_spec_per_pin *per_pin, int index)
>  
>  static void eld_proc_free(struct hdmi_spec_per_pin *per_pin)
>  {
> -	if (!per_pin->codec->bus->shutdown && per_pin->proc_entry) {
> +	if (!per_pin->codec->bus->shutdown) {
>  		snd_info_free_entry(per_pin->proc_entry);
>  		per_pin->proc_entry = NULL;
>  	}
> -- 
> 2.4.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/