linux-kernel - Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent to DEPCMD register fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Jun 2015 23:59:42 +0000
From:	John Youn <John.Youn@...opsys.com>
To:	"balbi@...com" <balbi@...com>, John Youn <John.Youn@...opsys.com>
CC:	Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@...inx.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Subbaraya Sundeep Bhatta <sbhatta@...inx.com>
Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent
 to DEPCMD register fails

On 6/29/2015 2:48 PM, Felipe Balbi wrote:
> Hi again,
> 
> On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote:
>> On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote:
>>> We need to return error to caller if command is not sent to
>>> controller succesfully.
>>>
>>> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@...inx.com>
>>> Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver)
>>> Cc: <stable@...r.kernel.org>
>>> ---
>>> v2 changes:
>>> 	Added Fixes and Cc in commit message.
>>
>> I noticed that this breaks at least my AM437x silicon with DWC3 2.40a
>> when used with g_zero and testusb. As of now, it could be that silicon
>> is mis-behaving because I got a Transfer Complete before the failing Set
>> Endpoint Transfer Resource command.
>>
>> In any case, can you run on your setup with g_zero and test.sh/testusb
>> [1]/[2] just to verify that it really works for you ?
>>
>> Meanwhile, I'll continue testing on my end.
>>
>> cheers
>>
>> [1] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:testusb.c
>> [2] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c81374aafb795c6e40:test.sh
> 
> Adding John here. John, any chance you could fire up dwc3 on HAPS and
> see wether it works or fails for you ?
> 

Sure. I'll try to get to it tomorrow.

John

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/