linux-kernel - Re: [PATCH v2 2/2] schedstat: Expose /proc/pid/schedstat if CONFIG_SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150630061649.GC15883@naverao1-tp.in.ibm.com>
Date:	Tue, 30 Jun 2015 11:46:49 +0530
From:	"Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
To:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
Cc:	bsingharora@...il.com, mingo@...nel.org,
	linux-kernel@...r.kernel.org, ricklind@...ibm.com,
	a.p.zijlstra@...llo.nl
Subject: Re: [PATCH v2 2/2] schedstat: Expose /proc/pid/schedstat if
 CONFIG_SCHED_INFO is set

On 2015/06/30 11:25AM, Srikar Dronamraju wrote:
> * Naveen N. Rao <naveen.n.rao@...ux.vnet.ibm.com> [2015-06-25 23:53:38]:
> 
> >  /*
> >   * Provides /proc/PID/schedstat
> >   */
> >  static int proc_pid_schedstat(struct seq_file *m, struct pid_namespace *ns,
> >  			      struct pid *pid, struct task_struct *task)
> >  {
> > -	seq_printf(m, "%llu %llu %lu\n",
> > +	if (unlikely(!sched_info_on()))
> > +		seq_printf(m, "0 0 0\n");
> > +	else
> > +		seq_printf(m, "%llu %lld %ld\n",
> 
> Should the above be seq_printf(m, "%llu %llu %lu\n", ?

Yikes! Nice catch, thanks! This looks to be left over from my tests with 
returning -1. Fixed patch on the way...

Regards,
Naveen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/