linux-kernel - Re: [PATCH v2] watchdog: omap_wdt: early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150630065807.GA5645@spo001.leaseweb.nl>
Date:	Tue, 30 Jun 2015 08:58:07 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	Guenter Roeck <linux@...ck-us.net>, poeschel@...onage.de,
	Jonathan Corbet <corbet@....net>,
	LKML doc <linux-doc@...r.kernel.org>,
	linux-watchdog@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>
Subject: Re: [PATCH v2] watchdog: omap_wdt: early_enable module parameter

Hi Paul,

> On Thu, Jun 25, 2015 at 9:46 AM, Guenter Roeck <linux@...ck-us.net> wrote:
> > On 06/25/2015 03:21 AM, poeschel@...onage.de wrote:
> >>
> >> From: Lars Poeschel <poeschel@...onage.de>
> >>
> >> Add a early_enable module parameter to the omap_wdt that starts the
> >> watchdog on module insertion. The default value is 0 which does not
> >> start the watchdog - which also does not change the behavior if the
> >> parameter is not given.
> >>
> >> Signed-off-by: Lars Poeschel <poeschel@...onage.de>
> >
> >
> > Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> 
> In case the info hasn't looped back around yet, this breaks the
> omap builds in linux-next:
> 
> drivers/watchdog/omap_wdt.c:288:18: error: 'omap_wdt' undeclared
> (first use in this function)
> 
> (Not sure how this could have ever worked as-is.)
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/12452335/
> 
> I see a patch has already been posted to arm-kernel but not
> Cc'd to all originally involved so figured I'd mention it.

It's fixed. The reason why we din't catch it was because of interference
with 'watchdog: omap: put struct watchdog_device into driver data'.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/