linux-kernel - Re: [PATCH] gpio: omap: prevent module from being unloaded while in use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVeFuK5j+s+Wj2kAHT7K9dj3RtK2aYZ50xDLb7S-73MJ7FTHA@mail.gmail.com>
Date:	Tue, 30 Jun 2015 22:52:21 +0900
From:	Alexandre Courbot <gnurou@...il.com>
To:	Grygorii Strashko <grygorii.strashko@...com>
Cc:	Linus Walleij <linus.walleij@...aro.org>, tony@...mide.com,
	Sekhar Nori <nsekhar@...com>,
	Santosh Shilimkar <ssantosh@...nel.org>,
	Javier Martinez Canillas <javier@...hile0.org>,
	Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: omap: prevent module from being unloaded while in use

On Fri, Jun 26, 2015 at 12:13 AM, Grygorii Strashko
<grygorii.strashko@...com> wrote:
> OMAP GPIO driver allowed to be built as loadable module, but it
> doesn't set owner field in GPIO chip structure. As result,
> module_get/put() API is not working and it's possible to unload
> OMAP driver while in use:
>
>   omap_gpio 48051000.gpio: REMOVING GPIOCHIP WITH GPIOS STILL REQUESTED
>
> Hence, add missing configuration.

Isn't this also fixed by your other patch "gpiolib: assign chip owner
to dev->driver->owner if not set"?

Nevertheless,

Acked-by: Alexandre Courbot <acourbot@...dia.com>

For inclusion into -rc if the other patch is for the next cycle.

>
> Cc: Tony Lindgren <tony@...mide.com>
> Fixes: cac089f9026e ('gpio: omap: Allow building as a loadable module')
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> ---
> Hi Linus,
>
> Seems this one is for 4.2-rc.
>
>  drivers/gpio/gpio-omap.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index a0ad803..61a731f 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1187,6 +1187,7 @@ static int omap_gpio_probe(struct platform_device *pdev)
>         bank->irq = res->start;
>         bank->dev = dev;
>         bank->chip.dev = dev;
> +       bank->chip.owner = THIS_MODULE;
>         bank->dbck_flag = pdata->dbck_flag;
>         bank->stride = pdata->bank_stride;
>         bank->width = pdata->bank_width;
> --
> 2.4.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/