linux-kernel - Re: [PATCH] usb: move assignment out of if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150630150956.GA17497@kroah.com>
Date:	Tue, 30 Jun 2015 08:09:56 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Kris Borer <kborer@...il.com>
Cc:	stern@...land.harvard.edu, balbi@...com, pmladek@...e.cz,
	antoine.tenart@...e-electrons.com, hdegoede@...hat.com,
	sergei.shtylyov@...entembedded.com, rafael.j.wysocki@...el.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: move assignment out of if condition

On Tue, Jun 30, 2015 at 09:02:22AM -0400, Kris Borer wrote:
> Fix four occurrences of the checkpatch.pl error:
> 
> ERROR: do not use assignment in if condition

If you are going to do stuff like this, use Coccinelle so you are sure
you don't break the code.

Also always test your changes, if possible.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/