linux-kernel - Re: [4.1.0-07254-gc13c810] Regression: Bluetooth not working.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150630114726.1f21fbb6@tedd-fedora-vm>
Date:	Tue, 30 Jun 2015 11:47:26 -0700
From:	Tedd Ho-Jeong An <tedd.an@...el.com>
To:	Jörg Otte <jrg.otte@...il.com>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	Marcel Holtmann <marcel@...tmann.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	"bluez mailin list (linux-bluetooth@...r.kernel.org)" 
	<linux-bluetooth@...r.kernel.org>,
	inux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [4.1.0-07254-gc13c810] Regression: Bluetooth not working.

Hi Jörg

On Tue, 30 Jun 2015 16:58:13 +0200
Jörg Otte <jrg.otte@...il.com> wrote:

> > Regarding the system hang issue, it looks like the problem is caused by the list_del().
> > According to the list.h, this macro puts the entry into invalid state and it causes the device hang in the l2cap_core.c
> >
> >     /**
> >      * list_del - deletes entry from list.
> >      * @entry: the element to delete from the list.
> >      * Note: list_empty() on entry does not return true after this, the entry is
> >      * in an undefined state.
> >      */
> >
> > So, one way to fix this issue is using the list_del_init() instead.
> >
> > Can you try this patch to see if it resolve the issue? No need to revert any patch.
> > I ran a quick test with a different scenarios and it looks good to me so far.
> >
> > diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> > index 51594fb..45fffa4 100644
> > --- a/net/bluetooth/l2cap_core.c
> > +++ b/net/bluetooth/l2cap_core.c
> > @@ -1634,7 +1634,7 @@ void l2cap_unregister_user(struct l2cap_conn *conn, struct l2cap_user *user)
> >         if (list_empty(&user->list))
> >                 goto out_unlock;
> >
> > -       list_del(&user->list);
> > +       list_del_init(&user->list);
> >         user->remove(conn, user);
> >
> >  out_unlock:
> > @@ -1648,7 +1648,7 @@ static void l2cap_unregister_all_users(struct l2cap_conn *conn)
> >
> >         while (!list_empty(&conn->users)) {
> >                 user = list_first_entry(&conn->users, struct l2cap_user, list);
> > -               list_del(&user->list);
> > +               list_del_init(&user->list);
> >                 user->remove(conn, user);
> >         }
> >  }
> >
> > Regards,
> > Tedd Ho-Jeong An
> 
> I now have both patche applied and no revert. Looks good so far.
> 
> Thanks, Jörg

Thanks for testing the patch. I submitted the patch just in case.
Now, I am tossing the ball to Marcel. :)

Regards,
Tedd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/