| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1435691026.12101.21.camel@perches.com> Date: Tue, 30 Jun 2015 12:03:46 -0700 From: Joe Perches <joe@...ches.com> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: devel@...verdev.osuosl.org, gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org, noralf@...nnes.org, Fabio Falzoi <fabio.falzoi84@...il.com> Subject: Re: [PATCH 07/10] Staging: fbtft: Remove useless newline On Tue, 2015-06-30 at 20:45 +0300, Dan Carpenter wrote: > On Tue, Jun 30, 2015 at 07:55:42AM -0700, Joe Perches wrote: > > On Tue, 2015-06-30 at 10:42 +0300, Dan Carpenter wrote: > > > On Tue, Jun 30, 2015 at 08:43:14AM +0200, Fabio Falzoi wrote: > > > > No newline is needed since checkpatch doesn't complain about line longer > > > > than 80 characters for string literals. > > [] > > > The original was correct. > > > > The original was fine. > > > > > There was no need to go over 80 characters > > > just because of a limitation in checkpatch. > > > > How is checkpatch not emitting a message on > > either form a limitation? > > It's not an easily solvable limitation, It's not a limitation at all. > but the original was better than > the new patch. This patch is all like "I've found a way to do something > bad and checkpatch.pl doesn't catch it so woohoo!" I think either form is fine, but because either is fine, it's not useful/better to change either. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists