linux-kernel - Re: [PATCH/RFC 0/3] of/overlay: Update aliases when added or removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150630172439.91ACAC4053E@trevor.secretlab.ca>
Date:	Tue, 30 Jun 2015 18:24:39 +0100
From:	Grant Likely <grant.likely@...aro.org>
To:	Geert Uytterhoeven <geert+renesas@...der.be>,
	Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
	Rob Herring <robh+dt@...nel.org>
Cc:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH/RFC 0/3] of/overlay: Update aliases when added or
 removed

On Tue, 30 Jun 2015 16:51:13 +0200
, Geert Uytterhoeven <geert+renesas@...der.be>
 wrote:
> 	Hi,
> 
> Currently the list of aliases is not updated when a DT overlay that adds
> an alias is loaded or unloaded. This break drivers (e.g. serial) that
> rely on of_alias_get_id(). This RFC patch series fixes that.
> 
> This is definitely not a final solution to be applied, as (1) it doesn't
> fix all possible cases, and as (2) there's an unresolved issue w.r.t.
> object lifetime. More about this in the last patch.
> 
> But it's Good Enough For My Use Case(TM), which is enabling/disabling
> serial ports on expansion headers by (un)loading DTBOs.
> 
> Thanks for your comments!
> 
> Geert Uytterhoeven (3):
>   [RFC] of: Extract of_alias_create()
>   [RFC] of: Add of_alias_destroy()
>   [RFC] of/dynamic: Update list of aliases on aliases changes

Looks good to me. I've made comments on patch 3. Also, you'll need to
include unittests before I can merge it.

g.

> 
>  drivers/of/base.c    | 72 +++++++++++++++++++++++++++++++++-------------------
>  drivers/of/dynamic.c | 24 ++++++++++++++++++
>  include/linux/of.h   |  3 +++
>  3 files changed, 73 insertions(+), 26 deletions(-)
> 
> -- 
> 1.9.1
> 
> Gr{oetje,eeting}s,
> 
> 						Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> 							    -- Linus Torvalds

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/