linux-kernel - Re: [PATCH v2 3/5] ARM: dts: rcm-k1879xb1: Add dts files for K1879XB1YA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Jun 2015 23:07:42 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Andrew Andrianov <andrew@...mnt.org>
Cc:	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	Rob Herring <robh+dt@...nel.org>,
	Pavel Shevchenko <pshevch@...ule.ru>,
	Andrew Andrianov <andrianov@...ule.ru>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] ARM: dts: rcm-k1879xb1: Add dts files for K1879XB1YA

On Tuesday 30 June 2015 18:15:05 Andrew Andrianov wrote:
> +	memory {
> +		device_type = "memory";
> +		reg = <0x40000000 0x8000000>;
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS0,38400n8 earlyprintk=serial";
> +	};

Can you use earlycon instead?

> +
> +	clocks {
> +			clk_core: clk_core@...M {
> +				/* Core 324MHz clock. */
> +				compatible = "fixed-factor-clock";
> +				#clock-cells = <0>;
> +				clocks = <&oscillator_27m>;
> +				clock-div = <1>;
> +				clock-mult = <12>;
> +				clock-output-names = "clk_core";
> +			};

Indentation looks wrong.

> +	axi {
> +		compatible = "arm,amba-bus";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0 0x0 0xFFFFFFFF>;
> +
> +		usbehci: ehci@...0040000 {
> +			compatible = "generic-ehci";
> +			reg = <0x10040000 0x2000>;
> +			interrupt-parent = <&vic1>;
> +			interrupts = <3>; /* 35 */
> +			status = "disabled";
> +		};
> +

Please use standard node names, e.g. "usb" instead of "ehci" and "ohci",
and "serial" instead of "uart".

> +
> +		dvb_ci0: dvb-ci@...50000 {
> +			compatible = "rcm,mdvbci";
> +			reg = <0x10050000 0x10000>;
> +			interrupts = <37>;
> +		};
> +
> +		xdmac0: xdmac@...70000 {
> +			compatible = "rcm,xdmac";
> +			reg = <0x10070000 0x10000>;
> +			interrupts = <16 17 18 19 20 21 22 23>;
> +		};

Remove the nodes that don't have an established binding for now.

> +		pinmux: sysconfigh@...0033084 {
> +			compatible = "rcm,pinmux";
> +			reg = <0x20033084 0x4>;
> +			reg-names = "controlH";
> +		};

This looks like it's only one register out of a larger area of
random things. Can you use a "syscon" device instead"?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/