linux-kernel - Re: [PATCH] un-improve strrchr()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEUsAPayae0imM3E_+UxaE8yztO3r9HCR02OP=k7kGOZgrVwGQ@mail.gmail.com>
Date:	Tue, 30 Jun 2015 18:52:11 -0500
From:	Chris Rorvick <chris@...vick.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux@...musvillemoes.dk
Subject: Re: [PATCH] un-improve strrchr()

[ resending w/o HTML formatting ]

On Sun, Jun 28, 2015 at 11:44 AM, Alexey Dobriyan <adobriyan@...il.com> wrote:
> Previous code did 1 branch per character + 1 branch for every character
> in the last path component. Current code does 2 branches per characher
> regardless.

Shouldn't that be "+ 2 branches for every character in the last path
component"?  The structure of the loop is basically the same; you're
just performing fewer iterations if the character is found when
searching from the end.

Regards,

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/