linux-kernel - Re: [PATCH 1/1] mfd: remove unnecessary check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 1 Jul 2015 08:39:50 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Maninder Singh <maninder1.s@...sung.com>
Cc:	sameo@...ux.intel.com, linux-kernel@...r.kernel.org,
	pankaj.m@...sung.com
Subject: Re: [PATCH 1/1] mfd: remove unnecessary check

On Tue, 30 Jun 2015, Maninder Singh wrote:

>  o Making pdata NULL check to (!pdata) as coding statndard
> 	and all other checks in file.
>  o Removing redundant check of pdata, because we already
> 	check for pdata, and also derefernced before this check
> 
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Reviewed-by: Vaneet Narang <v.narang@...sung.com>
> ---
>  drivers/mfd/t7l66xb.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, with a properly formatted subject line.

> diff --git a/drivers/mfd/t7l66xb.c b/drivers/mfd/t7l66xb.c
> index c09fb5d..854b05f 100644
> --- a/drivers/mfd/t7l66xb.c
> +++ b/drivers/mfd/t7l66xb.c
> @@ -318,7 +318,7 @@ static int t7l66xb_probe(struct platform_device *dev)
>  	struct resource *iomem, *rscr;
>  	int ret;
>  
> -	if (pdata == NULL)
> +	if (!pdata)
>  		return -EINVAL;
>  
>  	iomem = platform_get_resource(dev, IORESOURCE_MEM, 0);
> @@ -371,7 +371,7 @@ static int t7l66xb_probe(struct platform_device *dev)
>  
>  	clk_prepare_enable(t7l66xb->clk48m);
>  
> -	if (pdata && pdata->enable)
> +	if (pdata->enable)
>  		pdata->enable(dev);
>  
>  	/* Mask all interrupts */

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/