linux-kernel - Re: [PATCH/RFC v2 1/5] leds: Use set_brightness_work for brightness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150701094258.GS11162@sirena.org.uk>
Date:	Wed, 1 Jul 2015 10:42:58 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Sakari Ailus <sakari.ailus@....fi>
Cc:	Jacek Anaszewski <j.anaszewski@...sung.com>,
	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
	cooloney@...il.com, rpurdie@...ys.net, stsp@...rs.sourceforge.net,
	pavel@....cz, sakari.ailus@...ux.intel.com, andreas.werner@....de,
	andrew@...n.ch, ospite@...denti.unina.it, anemo@....ocn.ne.jp,
	ben@...tec.co.uk, bootc@...tc.net, dmurphy@...com,
	daniel.jeong@...com, daniel@...que.org, davem@...emloft.net,
	fabio.baltieri@...il.com, balbi@...com, florian@...nwrt.org,
	gshark.jeong@...il.com, g.liakhovetski@....de,
	ingi2.kim@...sung.com, dl9pf@....de, johan@...nel.org,
	lenz@...wisc.edu, jogo@...nwrt.org, q1.kim@...sung.com,
	kris@...sk.org, kristoffer.ericson@...il.com,
	linus.walleij@...aro.org, michael.hennerich@...log.com,
	milo.kim@...com, nm127@...email.hu, ncase@...-inc.com,
	neilb@...e.de, nick.forbes@...epta.com, lost.distance@...oo.com,
	p.meerwald@...-electronic.com, n0-1@...ewrt.org,
	philippe.retornaz@...l.ch, raph@...com, rpurdie@...nedhand.com,
	rod@...tby.id.au, dave@...1.net, giometti@...ux.it,
	bigeasy@...utronix.de, shuahkhan@...il.com, sguinot@...ie.com
Subject: Re: [PATCH/RFC v2 1/5] leds: Use set_brightness_work for
 brightness_set ops that can sleep

On Wed, Jul 01, 2015 at 01:24:50AM +0300, Sakari Ailus wrote:

> The documentation should be improved to tell how the API is expected to be
> have, e.g. which functions may block. I think this is out of scope for this
> patch though.

> I think all the existing drivers that implement the set_brightness()
> callback have a fast (and non-blocking) implementation, and some of these

Yes, they need to be since triggers can happen in any context.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)