linux-kernel - Re: [PATCH 1/4] mremap: don't leak new_vma if f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150701154623.GA14934@redhat.com>
Date:	Wed, 1 Jul 2015 17:46:23 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Benjamin LaHaise <bcrl@...ck.org>,
	Hugh Dickins <hughd@...gle.com>,
	Jeff Moyer <jmoyer@...hat.com>,
	Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] mremap: don't leak new_vma if f_op->mremap() fails

On 06/30, David Rientjes wrote:
>
> On Sat, 20 Jun 2015, Oleg Nesterov wrote:
>
> > move_vma() can't just return if f_op->mremap() fails, we should
> > unmap the new vma like we do if move_page_tables() fails. To avoid
> > the code duplication this patch moves the "move entries back" under
> > the new "if (err)" branch.
> >
> > Signed-off-by: Oleg Nesterov <oleg@...hat.com>
>
> Looks good!  I think it was sniped by commit 4abad2ca4a4d ("mm: new
> arch_remap() hook")

No, it was b2edffdd912b "fix mremap() vs. ioctx_kill() race"

> so it needs to be rebased,

Yes, thanks, I'll rebase...

But you know, I think 4abad2ca4a4d ("mm: new arch_remap() hook") should
be reverted later. Please see

	[PATCH v2 1/1] mm: move ->mremap() from file_operations to vm_operations_struct
	http://marc.info/?l=linux-kernel&m=143526519407521

I think arch_remap() should be turned into special_mapping_vmops->nremap().
But this is off-topic right now.

> but after that feel free to add my
>
 	Acked-by: David Rientjes <rientjes@...gle.com>

Thanks!

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/