linux-kernel - Re: [PATCH v2 11/12] ASoC: tegra: register dependency parser for firmware nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150701173802.GW11162@sirena.org.uk>
Date:	Wed, 1 Jul 2015 18:38:02 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Tomeu Vizoso <tomeu.vizoso@...labora.com>
Cc:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
	linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-pwm@...r.kernel.org, "Rafael J. Wysocki" <rjw@...ysocki.net>,
	alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
	Thierry Reding <thierry.reding@...il.com>,
	Takashi Iwai <tiwai@...e.de>,
	Stephen Warren <swarren@...dotorg.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-tegra@...r.kernel.org, Alexandre Courbot <gnurou@...il.com>
Subject: Re: [PATCH v2 11/12] ASoC: tegra: register dependency parser for
 firmware nodes

On Wed, Jul 01, 2015 at 11:41:06AM +0200, Tomeu Vizoso wrote:

> +static void tegra_max98090_get_dependencies(struct fwnode_handle *fwnode,
> +					    struct list_head *deps)
> +{
> +	add_dependency(fwnode, "nvidia,i2s-controller", deps);
> +	add_dependency(fwnode, "nvidia,audio-codec", deps);
> +}

Why is this all being open coded in an individual driver (we already
know about and manage all these dependencies in the core...)?  If we're
going to do this I'd expect the interface for specifying DT nodes to the
core to be changed to support this.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)