linux-kernel - Re: [PATCH V2 2/3] hwmon:f71882fg fix f81866a temp/beep setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <559455C7.3030002@roeck-us.net>
Date:	Wed, 01 Jul 2015 14:04:07 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Peter Hung <hpeter@...il.com>, jdelvare@...e.de
CC:	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org,
	tom_tsai@...tek.com.tw, peter_hong@...tek.com.tw,
	Peter Hung <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH V2 2/3] hwmon:f71882fg fix f81866a temp/beep setting

Hi Peter,

On 06/29/2015 06:31 PM, Peter Hung wrote:
> The temperature value of Fintek F81866 is the same with
> f71882fg. It located with 0x6c + 2*(nr), others located
> with 0x6c + 2*(nr+1). We change the rule in f71882fg_probe(),
> If type = f71858fg/f8000/f81866a. the temp_start will set to 0,
> others are 1.
>
> The F81866 over-temperature beep setting is not the same with
> f71882fg too. They are using the same address 63H, but F81866 is
> using bit 0/1/2 & 4/5/6, others are using bit 1/2/3 & 5/6/7,
> So we copy from fxxxx_temp_beep_attr[] to f81866_temp_beep_attr
> and change bit setting.
>
> Signed-off-by: Peter Hung <hpeter+linux_kernel@...il.com>
> ---
[ .. ]

> +			if (data->type == f81866a) {
> +				size = ARRAY_SIZE(f81866_temp_beep_attr[0]);
> +				err = f71882fg_create_sysfs_files(pdev,
> +						&f81866_temp_beep_attr[0][0],
> +						size * nr_temps);
> +
> +			} else {
> +				size = ARRAY_SIZE(fxxxx_temp_beep_attr[0];

TskTsk ... turns out you didn't even compile test this code.

How am I supposed to know that it is working ?

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/