linux-kernel - Re: [PATCH v1 05/10] device property: add fwnode_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2843363.SN8sM9ebvO@vostro.rjw.lan>
Date:	Thu, 02 Jul 2015 01:38:37 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Tomeu Vizoso <tomeu.vizoso@...labora.com>
Cc:	linux-kernel@...r.kernel.org, Mark Brown <broonie@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v1 05/10] device property: add fwnode_get_name()

On Tuesday, June 30, 2015 04:55:03 PM Tomeu Vizoso wrote:
> Getting a textual representation of a device node can be very useful for
> debugging.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>

Fine by me.


> ---
> 
>  drivers/base/property.c  | 15 +++++++++++++++
>  include/linux/property.h |  2 ++
>  2 files changed, 17 insertions(+)
> 
> diff --git a/drivers/base/property.c b/drivers/base/property.c
> index a7fb46b..3280b04 100644
> --- a/drivers/base/property.c
> +++ b/drivers/base/property.c
> @@ -556,3 +556,18 @@ struct fwnode_handle *fwnode_get_parent(struct fwnode_handle *fwnode)
>  	return NULL;
>  }
>  EXPORT_SYMBOL_GPL(fwnode_get_parent);
> +
> +/**
> + * fwnode_get_name - return the name of a device node
> + * @fwnode: Device node to find the name of
> + */
> +const char *fwnode_get_name(struct fwnode_handle *fwnode)
> +{
> +	if (is_of_node(fwnode))
> +		return to_of_node(fwnode)->full_name;
> +	else if (is_acpi_node(fwnode))
> +		return acpi_dev_name(to_acpi_node(fwnode));
> +
> +	return NULL;
> +}
> +EXPORT_SYMBOL_GPL(fwnode_get_name);
> diff --git a/include/linux/property.h b/include/linux/property.h
> index f47092d..020a53c 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -65,6 +65,8 @@ struct fwnode_handle *device_get_next_child_node(struct device *dev,
>  
>  struct fwnode_handle *fwnode_get_parent(struct fwnode_handle *fwnode);
>  
> +const char *fwnode_get_name(struct fwnode_handle *fwnode);
> +
>  #define device_for_each_child_node(dev, child) \
>  	for (child = device_get_next_child_node(dev, NULL); child; \
>  	     child = device_get_next_child_node(dev, child))
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/