linux-kernel - Re: [PATCH] drm/rockchip: vop: remove hardware cursor window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5594E246.6090500@rock-chips.com>
Date:	Thu, 02 Jul 2015 15:03:34 +0800
From:	Mark yao <mark.yao@...k-chips.com>
To:	Heiko Stübner <heiko@...ech.de>
CC:	dri-devel@...ts.freedesktop.org, David Airlie <airlied@...ux.ie>,
	Daniel Kurtz <djkurtz@...omium.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Daniel Vetter <daniel@...ll.ch>,
	Rob Clark <robdclark@...il.com>, tfiga@...omium.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
	sandy.huang@...k-chips.com, dkm@...k-chips.com, zwl@...k-chips.com,
	xw@...k-chips.com
Subject: Re: [PATCH] drm/rockchip: vop: remove hardware cursor window

On 2015年07月01日 19:52, Heiko Stübner wrote:
> Hi Mark,
>
> Am Mittwoch, 1. Juli 2015, 17:49:33 schrieb Mark Yao:
>> hardware cursor windows only have some fixed size, and not support
>> width virtual, when move hardware cursor windows outside of left,
>> the display would be wrong, so this window can't for cursor now.
>>
>> And Tag hardware cursor window as a overlay is wrong, will make
>> userspace wrong behaviour.
>>
>> So just remove the hardware cursor window
>>
>> Signed-off-by: Mark Yao <mark.yao@...k-chips.com>
>> ---
>>   drivers/gpu/drm/rockchip/rockchip_drm_vop.c |    1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
>> b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 4603412..7373ba1 100644
>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
>> @@ -368,7 +368,6 @@ static const struct vop_win_data rk3288_vop_win_data[] =
>> { { .base = 0x40, .phy = &win01_data, .type = DRM_PLANE_TYPE_OVERLAY }, {
>> .base = 0x00, .phy = &win23_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base
>> = 0x50, .phy = &win23_data, .type = DRM_PLANE_TYPE_CURSOR }, -	{ .base =
>> 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY }, };
>>
>>   static const struct vop_data rk3288_vop = {
> you should probably also remove the
>
> 	static const struct vop_win_phy cursor_data
>
> completely then, as it is now unused?
>
>
> Heiko
>
>
>
OK

-- 
Ｍark


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/