linux-kernel - Re: [PATCH RFC 1/5] kdbus: fix typos in kdbus_conn_quota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANq1E4TDWi86onEnymA_s6+-Sg=bfA3joaMA-DHCq4pPAFPTVg@mail.gmail.com>
Date:	Thu, 2 Jul 2015 10:31:48 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Sergei Zviagintsev <sergei@...v.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...glemail.com>,
	Djalal Harouni <tixxdz@...ndz.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC 1/5] kdbus: fix typos in kdbus_conn_quota_inc()

Hi

On Sun, Jun 28, 2015 at 3:17 PM, Sergei Zviagintsev <sergei@...v.net> wrote:
> Signed-off-by: Sergei Zviagintsev <sergei@...v.net>
> ---
>  ipc/kdbus/connection.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

(I'm a fan of putting the actual typo-corrections into the
commit-msg-body, like: "allocations -> allocation" and "slice ->
slices", which makes reviewing such patches a lot easier.)

Reviewed-by: David Herrmann <dh.herrmann@...il.com>

Thanks
David

> diff --git a/ipc/kdbus/connection.c b/ipc/kdbus/connection.c
> index 9993753d11de..df072487e23c 100644
> --- a/ipc/kdbus/connection.c
> +++ b/ipc/kdbus/connection.c
> @@ -646,7 +646,7 @@ int kdbus_conn_quota_inc(struct kdbus_conn *c, struct kdbus_user *u,
>          * allocation schemes. Furthermore, resource utilization should be
>          * maximized, so only minimal resources stay reserved. However, we need
>          * to adapt to a dynamic number of users, as we cannot know how many
> -        * users will talk to a connection. Therefore, the current allocations
> +        * users will talk to a connection. Therefore, the current allocation
>          * works like this:
>          * We limit the number of bytes in a destination's pool per sending
>          * user. The space available for a user is 33% of the unused pool space
> @@ -688,7 +688,7 @@ int kdbus_conn_quota_inc(struct kdbus_conn *c, struct kdbus_user *u,
>
>         /*
>          * Pool owner slices are un-accounted slices; they can claim more
> -        * than 50% of the queue. However, the slice we're dealing with here
> +        * than 50% of the queue. However, the slices we're dealing with here
>          * belong to the incoming queue, hence they are 'accounted' slices
>          * to which the 50%-limit applies.
>          */
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/