linux-kernel - Re: [PATCH v2] regulator: wm831x-dcdc: Use pointer after NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150702101849.GB16517@opensource.wolfsonmicro.com>
Date:	Thu, 2 Jul 2015 11:18:49 +0100
From:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:	Maninder Singh <maninder1.s@...sung.com>
Cc:	lgirdwood@...il.com, broonie@...nel.org,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org,
	pankaj.m@...sung.com
Subject: Re: [PATCH v2] regulator: wm831x-dcdc: Use pointer after NULL check

On Thu, Jul 02, 2015 at 01:27:09PM +0530, Maninder Singh wrote:
> pdata is used before NULL check, so it looks misleading.
> If pdata validation is required then we have to
> first check for pdata validation, then calculate id,
> and then second check for pdata->dcdc[id].
> 
> and it is better to use !pointer than (pointer == NULL)
> 
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> ---

The patch basically looks fine, but it feels a bit like needless
churn. The current code is perfectly correct and feels clear
enough to me.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/