linux-kernel - RE: [f2fs-dev] [PATCH 1/2] f2fs: refactor shrink flow for extent cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <COL402-EAS125E9214A5E90E6EF1FA7F5AB970@phx.gbl>
Date:	Thu, 2 Jul 2015 20:37:11 +0800
From:	Chao Yu <yuchaochina@...mail.com>
To:	"'Jaegeuk Kim'" <jaegeuk@...nel.org>,
	"'Chao Yu'" <chao2.yu@...sung.com>
CC:	<linux-kernel@...r.kernel.org>,
	<linux-f2fs-devel@...ts.sourceforge.net>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [f2fs-dev] [PATCH 1/2] f2fs: refactor shrink flow for extent	cache

Hi Jaegeuk,

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@...nel.org]
> Sent: Wednesday, July 01, 2015 9:26 AM
> To: Chao Yu; Chao Yu
> Cc: linux-kernel@...r.kernel.org; linux-f2fs-devel@...ts.sourceforge.net;
> linux-kernel@...r.kernel.org; linux-f2fs-devel@...ts.sourceforge.net
> Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: refactor shrink flow for extent cache
> 
> Hi Chao,
> 
> On Tue, Jun 30, 2015 at 06:42:09PM +0800, Chao Yu wrote:
> > For now, in extent cache, we have a global lru list which links all extent
> > node in the cache, and the list is protected by a global spinlock.
> >
> > If we want to shrink extent cache, we will:
> > 1. delete all target extent node from global lru list under spinlock;
> > 2. traverse all per-inode extent tree in global radix tree;
> > 	2.a. traverse all extent node in per-inode extent tree, try to free extent
> >          node if it is not in global lru list already.
> >
> > This method is inefficient when there is huge number of inode extent tree in
> > global extent tree.
> >
> > In this patch we introduce a new method for extent cache shrinking:
> > When we attach a new extent node, we record extent tree pointer in extent node.
> > In shrink flow, we can try to find and lock extent tree of inode directly by
> > this backward pointer, and then detach the extent node from extent tree.
> >
> > This can help to shrink extent cache more efficiently.
> 
> Yes, but as we discussed before, this way will consume 4 bytes per each
> extent_node. Can it be acceptable?

Yes, this method will increase memory overhead obviously.

Maybe there is a better way to reduce lock contention and block time
of shrinker maked. I will rethink about it.

What I think now is I should firstly tests on our new shrinker with
extreme case to see how bad it shows.

> 
> Instead, IMO, we need to focus on how to increase its hit ratio first.
> Actually, I wrote a patch for that.
> Could you check that first?

OK

Thanks,

> 
> Thanks,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/