linux-kernel - RE: [f2fs-dev] [PATCH 11/12] f2fs: add noextent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <COL402-EAS3119D4AFA99D9454639B68CAB970@phx.gbl>
Date:	Thu, 2 Jul 2015 20:35:34 +0800
From:	Chao Yu <yuchaochina@...mail.com>
To:	"'Jaegeuk Kim'" <jaegeuk@...nel.org>,
	<linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
	<linux-f2fs-devel@...ts.sourceforge.net>
Subject: RE: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@...nel.org]
> Sent: Tuesday, June 30, 2015 2:40 AM
> To: linux-kernel@...r.kernel.org; linux-fsdevel@...r.kernel.org;
> linux-f2fs-devel@...ts.sourceforge.net
> Cc: Jaegeuk Kim
> Subject: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option
> 
> This patch adds noextent_cache mount option.

How about adding some descriptions in Documentation to help our user?

The other thing is we'd better to show 'noextent_cache' option when user
lookups the mount options.

How about adding codes as below?
if (test_opt(sbi, EXTENT_CACHE))
	seq_puts(seq, ",extent_cache");
+else
+	seq_puts(seq, ",noextent_cache");

> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>

The other looks good to me, so please add:

Reviewed-by: Chao Yu <chao2.yu@...sung.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/