linux-kernel - Re: [PATCH] block:Fix various function return statements to comply with function's return type in blk-throttle.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5595488F.6040906@kernel.dk>
Date:	Thu, 02 Jul 2015 08:19:59 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Nicholas Krause <xerofoify@...il.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block:Fix various function return statements to comply
 with function's return type in blk-throttle.c

On 07/02/2015 08:13 AM, Nicholas Krause wrote:
> This fixes various functions in the file blk-throttle.c with the
> return type of bool to return true/false rather then one/zero
> in order to better comply with these functions having a return
> type of bool.

Nicholas, stop sending me patches, I told you that last time too. I 
appreciate the effort, but there's always one or two errors in your 
patches. They are often not even compile tested, and definitely never 
runtime tested. Hence the risk/reward ratio just isn't great, and I 
don't want to apply them. Example from this patch:

> @@ -855,7 +855,7 @@ static bool tg_with_in_iops_limit(struct throtl_grp *tg, struct bio *bio,
>
>   	if (wait)
>   		*wait = jiffy_wait;
> -	return 0;
> +	return true;
>   }
>
>   static bool tg_with_in_bps_limit(struct throtl_grp *tg, struct bio *bio,

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/