linux-kernel - Re: [PATCH 2/2] perf,tools: check and re-organize evsel cpu maps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150702160803.GA19742@krava.brq.redhat.com>
Date:	Thu, 2 Jul 2015 18:08:03 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	"acme@...nel.org" <acme@...nel.org>
Cc:	"Liang, Kan" <kan.liang@...el.com>,
	"jolsa@...nel.org" <jolsa@...nel.org>,
	"ak@...ux.intel.com" <ak@...ux.intel.com>,
	"namhyung@...nel.org" <namhyung@...nel.org>,
	"eranian@...gle.com" <eranian@...gle.com>,
	"Hunter, Adrian" <adrian.hunter@...el.com>,
	"dsahern@...il.com" <dsahern@...il.com>,
	"a.p.zijlstra@...llo.nl" <a.p.zijlstra@...llo.nl>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] perf,tools: check and re-organize evsel cpu maps

On Tue, Jun 30, 2015 at 11:42:25AM -0300, acme@...nel.org wrote:
> Em Tue, Jun 30, 2015 at 03:54:49PM +0200, Jiri Olsa escreveu:
> > On Tue, Jun 30, 2015 at 01:42:49PM +0000, Liang, Kan wrote:
> > > > > +static int perf_evlist__check_evsel_cpus(struct perf_evlist *evlist,
> > > > > +struct perf_evsel *evsel) {
> > > > > +	const struct cpu_map *cpus = evlist->cpus;
> > > > > +	const int ncpus = cpu_map__nr(evlist->cpus);
> > > > > +	int j = 0, cpu_nr = 0, tmp = 0;
> > > > > +	int i;
> > > > > +
> > > > > +	/* ensure we process id in increasing order */
> > > > > +	qsort(evlist->cpus->map, evlist->cpus->nr, sizeof(int), cmp_ids);
> > > > 
> > > > wouldn't sorting maps affect some other code?
> > > > 
> > > 
> > > I didn't find any bad effect after sorting the maps.
> > > Any codes I need to check?
> > 
> > I dont think so, but I'm not sure either.. thats why I asked ;-)
> > 
> > I guess any code dealing with cpu maps.. it might affect
> > perf stat output.. but it looks sorted now anyway ;-)
> > I dont think it's an issue
> 
> Is this being done at cpu_map__new time, i.e. when we first parse it?

it's done within perf_evlist__create_maps.. checking the v2

jirka

> That way any assumption about repositioning gets out of the way.
> 
> - Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/