linux-kernel - Re: [PATCH 1/1] mfd: remove unnecessary check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 2 Jul 2015 09:14:57 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Maninder Singh <maninder1.s@...sung.com>,
	sameo@...ux.intel.com, linux-kernel@...r.kernel.org,
	pankaj.m@...sung.com
Subject: Re: [PATCH 1/1] mfd: remove unnecessary check

2015-07-01 23:08 GMT+09:00 Lee Jones <lee.jones@...aro.org>:
> On Wed, 01 Jul 2015, Krzysztof Kozlowski wrote:
>
>> 2015-07-01 16:40 GMT+09:00 Lee Jones <lee.jones@...aro.org>:
>> > On Wed, 01 Jul 2015, Lee Jones wrote:
>> >> On Tue, 30 Jun 2015, Maninder Singh wrote:
>> >>
>> >> >  o Making pdata NULL check to (!pdata) as coding statndard
>> >> >     and all other checks in file.
>> >> >  o Removing redundant check of pdata, because we already
>> >> >     check for pdata, and also derefernced before this check
>> >> >
>> >> > Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
>> >> > Reviewed-by: Vaneet Narang <v.narang@...sung.com>
>> >> > ---
>> >> >  drivers/mfd/t7l66xb.c |    4 ++--
>> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >>
>> >> Applied, with a properly formatted subject line.
>> >
>> > Should have probably been more forthcomming with some advice.
>> >
>> > Next time, please use `git log --oneline -- <subsystem>` to see what
>> > the accepted format is.
>>
>> ... and a spell-check could be useful as well :). The reviewed-by tag
>> was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
>> so I think it should be dropped.
>
> Fair points.  Patch dropped.

I meant the reviewed-by tag should be dropped :) .

So now... Maninder Singh, could you resent the patch with this minor
issues fixed?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/