| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <55956AC1.9000902@users.sourceforge.net> Date: Thu, 02 Jul 2015 18:45:53 +0200 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org CC: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, kernel-janitors <kernel-janitors@...r.kernel.org>, Julia Lawall <julia.lawall@...6.fr> Subject: [PATCH] netlink: Delete an unnecessary check before the function call "module_put" From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Thu, 2 Jul 2015 18:38:12 +0200 The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- net/netlink/af_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index dea9253..9a0ae71 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -158,7 +158,7 @@ static int __netlink_remove_tap(struct netlink_tap *nt) out: spin_unlock(&netlink_tap_lock); - if (found && nt->module) + if (found) module_put(nt->module); return found ? 0 : -ENODEV; -- 2.4.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists