linux-kernel - Re: [PATCH 07/11] Input: synaptics-rmi4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Jul 2015 10:50:50 -0700
From:	Andrew Duggan <aduggan@...aptics.com>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Christopher Heiny <cheiny@...aptics.com>,
	Allie Xiong <axiong@...aptics.com>
CC:	Stephen Chandler Paul <cpaul@...hat.com>,
	<benjamin.tissoires@...il.com>, <linux-input@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	Vincent Huang <vincent.huang@...synaptics.com>
Subject: Re: [PATCH 07/11] Input: synaptics-rmi4 - f11: fix bitmap irq check

On 06/23/2015 12:17 PM, Benjamin Tissoires wrote:
> num_irq_regs is the count of registers of 1 bytes that we use to check
> the irqs. bitmap_and() expects the number of bits.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> ---

Reviewed-by: Andrew Duggan <aduggan@...aptics.com>

>   drivers/input/rmi4/rmi_f11.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
> index 99d6181..c3b757b 100644
> --- a/drivers/input/rmi4/rmi_f11.c
> +++ b/drivers/input/rmi4/rmi_f11.c
> @@ -726,12 +726,12 @@ static void rmi_f11_finger_handler(struct f11_data *f11,
>   		}
>   
>   		abs_bits = bitmap_and(f11->result_bits, irq_bits, f11->abs_mask,
> -				      num_irq_regs);
> +				      num_irq_regs * 8);
>   		if (abs_bits)
>   			rmi_f11_abs_pos_report(f11, sensor, finger_state, i);
>   
>   		rel_bits = bitmap_and(f11->result_bits, irq_bits, f11->rel_mask,
> -				      num_irq_regs);
> +				      num_irq_regs * 8);
>   		if (rel_bits)
>   			rmi_f11_rel_pos_report(sensor, i);
>   	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/