linux-kernel - Re: [PATCH 1/1] drivers: hv: hv_utils_transport: Fixing validation of correct pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <876161br1r.fsf@vitty.brq.redhat.com>
Date:	Fri, 03 Jul 2015 10:09:52 +0200
From:	Vitaly Kuznetsov <vkuznets@...hat.com>
To:	Maninder Singh <maninder1.s@...sung.com>, kys@...rosoft.com
Cc:	haiyangz@...rosoft.com, devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org, pankaj.m@...sung.com
Subject: Re: [PATCH 1/1] drivers: hv: hv_utils_transport: Fixing validation of correct pointer

Maninder Singh <maninder1.s@...sung.com> writes:

> cn_msg should be validated instead of msg after memory allocation.
>

Thanks,

This was already fixed by Dan:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-May/070193.html

my Reviewed-by:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-June/070599.html

but I don't see it in K. Y. recent submission to Greg. K. Y., could you
please pick it up?

> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Reviewed-by: Akhilesh Kumar <akhilesh.k@...sung.com>
> ---
>  drivers/hv/hv_utils_transport.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hv/hv_utils_transport.c b/drivers/hv/hv_utils_transport.c
> index ea7ba5e..6a9d80a 100644
> --- a/drivers/hv/hv_utils_transport.c
> +++ b/drivers/hv/hv_utils_transport.c
> @@ -186,7 +186,7 @@ int hvutil_transport_send(struct hvutil_transport *hvt, void *msg, int len)
>  		return -EINVAL;
>  	} else if (hvt->mode == HVUTIL_TRANSPORT_NETLINK) {
>  		cn_msg = kzalloc(sizeof(*cn_msg) + len, GFP_ATOMIC);
> -		if (!msg)
> +		if (!cn_msg)
>  			return -ENOMEM;
>  		cn_msg->id.idx = hvt->cn_id.idx;
>  		cn_msg->id.val = hvt->cn_id.val;

-- 
  Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/