linux-kernel - Re: [PATCH 4/4] phy: berlin-usb: rename table copied from SATA PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150703091831.GB5634@kwain>
Date:	Fri, 3 Jul 2015 11:18:31 +0200
From:	Antoine Tenart <antoine.tenart@...e-electrons.com>
To:	Thomas Hebb <tommyhebb@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	kishon@...com, antoine.tenart@...e-electrons.com,
	sebastian.hesselbarth@...il.com
Subject: Re: [PATCH 4/4] phy: berlin-usb: rename table copied from SATA PHY

Thomas,

On Thu, Jul 02, 2015 at 01:04:30AM -0400, Thomas Hebb wrote:
> We're not in a SATA PHY driver, so the of_match table shouldn't have
> "sata" in its name.

There is already a patch fixing this (which was sent last week):

https://lkml.org/lkml/2015/6/24/103

You can drop this one from the series.

Antoine

> 
> Signed-off-by: Thomas Hebb <tommyhebb@...il.com>
> Suggested-by: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
> ---
>  drivers/phy/phy-berlin-usb.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index 335e06d..7143cd3 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -152,7 +152,7 @@ static struct phy_ops phy_berlin_usb_ops = {
>  	.owner		= THIS_MODULE,
>  };
>  
> -static const struct of_device_id phy_berlin_sata_of_match[] = {
> +static const struct of_device_id phy_berlin_usb_of_match[] = {
>  	{
>  		.compatible = "marvell,berlin2-usb-phy",
>  		.data = &phy_berlin_pll_dividers[0],
> @@ -163,12 +163,12 @@ static const struct of_device_id phy_berlin_sata_of_match[] = {
>  	},
>  	{ },
>  };
> -MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match);
> +MODULE_DEVICE_TABLE(of, phy_berlin_usb_of_match);
>  
>  static int phy_berlin_usb_probe(struct platform_device *pdev)
>  {
>  	const struct of_device_id *match =
> -		of_match_device(phy_berlin_sata_of_match, &pdev->dev);
> +		of_match_device(phy_berlin_usb_of_match, &pdev->dev);
>  	struct phy_berlin_usb_priv *priv;
>  	struct resource *res;
>  	struct phy *phy;
> @@ -208,7 +208,7 @@ static struct platform_driver phy_berlin_usb_driver = {
>  	.driver	= {
>  		.name		= "phy-berlin-usb",
>  		.owner		= THIS_MODULE,
> -		.of_match_table	= phy_berlin_sata_of_match,
> +		.of_match_table	= phy_berlin_usb_of_match,
>  	 },
>  };
>  module_platform_driver(phy_berlin_usb_driver);
> -- 
> 2.4.4
> 

-- 
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/