linux-kernel - Re: Kconfig: '+config' valid syntax?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABv5NL_xyB2U6khOudBok_v_H0cw1E7m7uJ0iSPVn0DYW-w9Pg@mail.gmail.com>
Date:	Fri, 3 Jul 2015 13:11:19 +0200
From:	Stefan Hengelein <stefan.hengelein@....de>
To:	Valentin Rothberg <valentinrothberg@...il.com>
Cc:	Ulf Magnusson <ulfalizer.lkml@...il.com>,
	Andreas Ruprecht <andreas.ruprecht@....de>,
	Paul Bolle <pebolle@...cali.nl>, rafael.j.wysocki@...el.com,
	"open list:KCONFIG" <linux-kbuild@...r.kernel.org>,
	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux@...inikbrodowski.net
Subject: Re: Kconfig: '+config' valid syntax?

2015-07-03 12:56 GMT+02:00 Stefan Hengelein <stefan.hengelein@....de>:
> 2015-07-03 12:51 GMT+02:00 Valentin Rothberg <valentinrothberg@...il.com>:
>>>>
>>>> The output looks like this:
>>>> scripts/kconfig/conf  --allyesconfig Kconfig
>>>> arch/x86/Kconfig:4:warning: ignoring unsupported character '-'
>>>> arch/x86/Kconfig:4:warning: ignoring unsupported character '-'
>>>> arch/x86/Kconfig:4:warning: ignoring unsupported character '-'
>>>> init/Kconfig:222:warning: ignoring unsupported character '-'
>>>> init/Kconfig:222:warning: ignoring unsupported character '-'
>>>> init/Kconfig:222:warning: ignoring unsupported character '-'
>>>> init/Kconfig:244:warning: ignoring unsupported character '-'
>>>> init/Kconfig:244:warning: ignoring unsupported character '-'
>>>> init/Kconfig:244:warning: ignoring unsupported character '-'
>>>> [...]
>>>>
>>>> So we would need to add special treatment for '-' also in the command
>>>> case, right? But that doesn't look appealing to me, more like a dirty,
>>>> dirty hack around the actual problem...
>>>>
>>>> Regards,
>>>>
>>>> Andreas
>>>>
>>>
>>> Except for scattered accidents like in the original message, which are
>>> hopefully pretty rare and easy to fix, the only documented thing that depends
>>> on that lexer sloppiness is the ---help--- "token".
>>>
>>> I'd just add "---help---" as another T_HELP alias (or get rid of it altogether,
>>> but that's probably more work than it's worth). Tightening things up should be
>>> safe after that.
>>
>> This idea has a big ACK from me.  It seems to me the cleanest way to
>> solve the issue.
>>
>
> Agreed! I also wanted to suggest this solution, but Ulf was faster :)
>
> Kind Regards,
> Stefan

However, thinking about this solution a little more....
This change might lead to parser conflicts....shift-reduce conflicts maybe.

Is the '-' used somewhere else and has a distinct token or is it just
ignored and thrown away?


Kind Regards,
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/