linux-kernel - Re: Kconfig: '+config' valid syntax?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEMqcmq8OLZMtcPNCVK1Qt55aunxYeGx+PLSpc97rhK1gvXEiA@mail.gmail.com>
Date:	Fri, 3 Jul 2015 14:48:25 +0200
From:	Ulf Magnusson <ulfalizer.lkml@...il.com>
To:	Andreas Ruprecht <andreas.ruprecht@....de>
Cc:	Paul Bolle <pebolle@...cali.nl>,
	Valentin Rothberg <valentinrothberg@...il.com>,
	rafael.j.wysocki@...el.com,
	"open list:KCONFIG" <linux-kbuild@...r.kernel.org>,
	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	hengelein Stefan <stefan.hengelein@....de>,
	linux@...inikbrodowski.net
Subject: Re: Kconfig: '+config' valid syntax?

On Fri, Jul 3, 2015 at 2:39 PM, Ulf Magnusson <ulfalizer.lkml@...il.com> wrote:
> On Fri, Jul 3, 2015 at 1:40 PM, Ulf Magnusson <ulfalizer.lkml@...il.com> wrote:
>> On Fri, Jul 3, 2015 at 1:33 PM, Andreas Ruprecht
>> <andreas.ruprecht@....de> wrote:
>>> On 07/03/2015 12:46, Ulf Magnusson wrote:
>>>>
>>>> Except for scattered accidents like in the original message, which are
>>>> hopefully pretty rare and easy to fix, the only documented thing that depends
>>>> on that lexer sloppiness is the ---help--- "token".
>>>>
>>>> I'd just add "---help---" as another T_HELP alias (or get rid of it altogether,
>>>> but that's probably more work than it's worth). Tightening things up should be
>>>> safe after that.
>>>>
>>>> /Ulf
>>>>
>>>
>>> So we might want to do something like the attached patch, right?
>>>
>>> Unfortunately, when I generate the zconf.{hash,lex,tab}.c files on my
>>> machine, they have some notable differences to the _shipped versions:
>>>
>>> ruprecht@box:linux-next$ diff -u zconf.tab.c zconf.tab.c_shipped
>>> -  return yyresult;
>>> +  /* Make sure YYID is used.  */
>>> +  return YYID (yyresult);
>>>
>>> and I can't find any Documentation on how to properly rebuild the
>>> _shipped files... Does anybody have a hint on that?
>>>
>>> Regards,
>>>
>>> Andreas
>>
>> Yup, something like that. Been too long, so I don't remember either,
>> though I don't remember having to do anything special.
>>
>> I'm heading off to bed soon, so probably shouldn't be thinking. Could
>> take a look tomorrow if there's still a problem. :)
>>
>> /Ulf
>
> Or add '---help---' to zconf.gperf I guess, to avoid special-casing it. Would
> need to add '-' to the
>
> n    [A-Za-z0-9_]
>
> definition in zconf.l in that case too.
>
> That should be safe provided the gperf part works out, since zconf.y should
> verify that the T_WORD has the expected form. (As a side note, the first token
> on a line is always a keyword, except for within help texts, which are handled
> specially.)

...or that it's not a T_WORD rather, but a command. :P

>
> I guess that might change the meaning of lines like "foo-bar" if '-' is
> introduced as an operator, but that seems kinda academic as 'foo' would
> probably still be a keyword. It's already broken due to the <PARAM> regex
> ({n}|[-/.])+ having '-' in it too.
>
> /Ulf

/Ulf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/