linux-kernel - Re: [PATCH v3] usb: xhci: Add support for URB_ZERO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <559690AE.5050507@linux.intel.com>
Date:	Fri, 03 Jul 2015 16:39:58 +0300
From:	Mathias Nyman <mathias.nyman@...ux.intel.com>
To:	Reyad Attiyat <reyad.attiyat@...il.com>,
	Mathias Nyman <mathias.nyman@...el.com>
CC:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] usb: xhci: Add support for URB_ZERO_PACKET to bulk/sg
 transfers

On 02.07.2015 22:00, Reyad Attiyat wrote:
> This version of the patch changes last_trb varible name to
> last_trb_num and fixes code style. I have also added a td to the urb
> td array. This now gets prepared properl,y with prepare_transfer(),
> and is handled correctly when transferred and completed. It only calls
> the urb completion callback once as there is a check in finish_td() to
> ensure that all td's have been received.
> 
> If you think I should change anything else please let me know.
> 
> Thank you,
> Reyad Attiyat
> 
> On Thu, Jul 2, 2015 at 1:54 PM, Reyad Attiyat <reyad.attiyat@...il.com> wrote:
>> This commit checks for the URB_ZERO_PACKET flag and creates an extra
>> zero-length td if the urb transfer length is a multiple of the endpoint's
>> max packet length.
>>
>> Signed-off-by: Reyad Attiyat <reyad.attiyat@...il.com>
>> ---

Looks good, Thank you

I assume it works with your wireless card?

I'll go on a two weeks vacation starting now, but after that I'll 
send it forward. (it should go to usb-next and reach 4.3 kernel anyway)

-Mathias 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/