| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150703140206.GJ13481@lunn.ch>
Date: Fri, 3 Jul 2015 16:02:06 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Gregory CLEMENT <gregory.clement@...e-electrons.com>
Cc: Jason Cooper <jason@...edaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
linux-arm-kernel@...ts.infradead.org,
Mike Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...eaurora.org>, linux-clk@...r.kernel.org,
linux-kernel@...r.kernel.org,
Daniel Lezcano <daniel.lezcano@...aro.org>,
"Rafael J. Wysocki" <rjw@...ysocki.net>, linux-pm@...r.kernel.org,
Maxime Ripard <maxime.ripard@...e-electrons.com>,
Boris BREZILLON <boris.brezillon@...e-electrons.com>,
Lior Amsalem <alior@...vell.com>,
Tawfik Bayouk <tawfik@...vell.com>,
Nadav Haklai <nadavh@...vell.com>
Subject: Re: [PATCH RFC 2/5] ARM: mvebu: Use shorter register definition in
pmsu.c
On Fri, Jul 03, 2015 at 08:11:54AM +0200, Gregory CLEMENT wrote:
> The register definition were too verbose. Shorten them in order to
> have something more readable and avoiding having most of the
> instruction on two lines.
Hi Gregory
You say to avoid having most of the instructions on two lines, but if
you look at the diff, you don't actually achieve any line count
savings.
> Signed-off-by: Gregory CLEMENT <gregory.clement@...e-electrons.com>
> ---
> arch/arm/mach-mvebu/pmsu.c | 102 +++++++++++++++++++++++----------------------
> 1 file changed, 52 insertions(+), 50 deletions(-)
>
> diff --git a/arch/arm/mach-mvebu/pmsu.c b/arch/arm/mach-mvebu/pmsu.c
> index 4f4e22206ae5..d207f5fc13a6 100644
> --- a/arch/arm/mach-mvebu/pmsu.c
> +++ b/arch/arm/mach-mvebu/pmsu.c
> @@ -46,27 +46,29 @@
> #define PMSU_REG_SIZE 0x1000
>
> /* PMSU MP registers */
> -#define PMSU_CONTROL_AND_CONFIG(cpu) ((cpu * 0x100) + 0x104)
> -#define PMSU_CONTROL_AND_CONFIG_DFS_REQ BIT(18)
> -#define PMSU_CONTROL_AND_CONFIG_PWDDN_REQ BIT(16)
> -#define PMSU_CONTROL_AND_CONFIG_L2_PWDDN BIT(20)
> +#define PMSU_CTL_CFG(cpu) ((cpu * 0x100) + 0x104)
> +#define PMSU_CTL_CFG_CPU0_FRQ_ID_SFT 4
> +#define PMSU_CTL_CFG_CPU0_FRQ_ID_MSK 0xF
> +#define PMSU_CTL_CFG_DFS_REQ BIT(18)
> +#define PMSU_CTL_CFG_PWDDN_REQ BIT(16)
> +#define PMSU_CTL_CFG_L2_PWDDN BIT(20)
>
> #define PMSU_CPU_POWER_DOWN_CONTROL(cpu) ((cpu * 0x100) + 0x108)
>
> #define PMSU_CPU_POWER_DOWN_DIS_SNP_Q_SKIP BIT(0)
>
> -#define PMSU_STATUS_AND_MASK(cpu) ((cpu * 0x100) + 0x10c)
> -#define PMSU_STATUS_AND_MASK_CPU_IDLE_WAIT BIT(16)
> -#define PMSU_STATUS_AND_MASK_SNP_Q_EMPTY_WAIT BIT(17)
> -#define PMSU_STATUS_AND_MASK_IRQ_WAKEUP BIT(20)
> -#define PMSU_STATUS_AND_MASK_FIQ_WAKEUP BIT(21)
> -#define PMSU_STATUS_AND_MASK_DBG_WAKEUP BIT(22)
> -#define PMSU_STATUS_AND_MASK_IRQ_MASK BIT(24)
> -#define PMSU_STATUS_AND_MASK_FIQ_MASK BIT(25)
> +#define PMSU_STATUS_MSK(cpu) ((cpu * 0x100) + 0x10c)
> +#define PMSU_STATUS_MSK_CPU_IDLE_WAIT BIT(16)
> +#define PMSU_STATUS_MSK_SNP_Q_EMPTY_WAIT BIT(17)
> +#define PMSU_STATUS_MSK_IRQ_WAKEUP BIT(20)
> +#define PMSU_STATUS_MSK_FIQ_WAKEUP BIT(21)
> +#define PMSU_STATUS_MSK_DBG_WAKEUP BIT(22)
> +#define PMSU_STATUS_MSK_IRQ_MASK BIT(24)
> +#define PMSU_STATUS_MSK_FIQ_MASK BIT(25)
>
> -#define PMSU_EVENT_STATUS_AND_MASK(cpu) ((cpu * 0x100) + 0x120)
> -#define PMSU_EVENT_STATUS_AND_MASK_DFS_DONE BIT(1)
> -#define PMSU_EVENT_STATUS_AND_MASK_DFS_DONE_MASK BIT(17)
> +#define PMSU_EVENT_STATUS_MSK(cpu) ((cpu * 0x100) + 0x120)
> +#define PMSU_EVENT_STATUS_MSK_DFS_DONE BIT(1)
> +#define PMSU_EVENT_STATUS_MSK_DFS_DONE_MASK BIT(17)
>
> #define PMSU_BOOT_ADDR_REDIRECT_OFFSET(cpu) ((cpu * 0x100) + 0x124)
>
> @@ -238,23 +240,23 @@ static int mvebu_v7_pmsu_idle_prepare(unsigned long flags)
> * IRQ and FIQ as wakeup events, set wait for snoop queue empty
> * indication and mask IRQ and FIQ from CPU
> */
> - reg = readl(pmsu_mp_base + PMSU_STATUS_AND_MASK(hw_cpu));
> - reg |= PMSU_STATUS_AND_MASK_CPU_IDLE_WAIT |
> - PMSU_STATUS_AND_MASK_IRQ_WAKEUP |
> - PMSU_STATUS_AND_MASK_FIQ_WAKEUP |
> - PMSU_STATUS_AND_MASK_SNP_Q_EMPTY_WAIT |
> - PMSU_STATUS_AND_MASK_IRQ_MASK |
> - PMSU_STATUS_AND_MASK_FIQ_MASK;
> - writel(reg, pmsu_mp_base + PMSU_STATUS_AND_MASK(hw_cpu));
> -
> - reg = readl(pmsu_mp_base + PMSU_CONTROL_AND_CONFIG(hw_cpu));
> + reg = readl(pmsu_mp_base + PMSU_STATUS_MSK(hw_cpu));
> + reg |= PMSU_STATUS_MSK_CPU_IDLE_WAIT |
> + PMSU_STATUS_MSK_IRQ_WAKEUP |
> + PMSU_STATUS_MSK_FIQ_WAKEUP |
> + PMSU_STATUS_MSK_SNP_Q_EMPTY_WAIT |
> + PMSU_STATUS_MSK_IRQ_MASK |
> + PMSU_STATUS_MSK_FIQ_MASK;
You can probably get two per line here?
> + writel(reg, pmsu_mp_base + PMSU_STATUS_MSK(hw_cpu));
> +
> + reg = readl(pmsu_mp_base + PMSU_CTL_CFG(hw_cpu));
> /* ask HW to power down the L2 Cache if needed */
> if (flags & PMSU_PREPARE_DEEP_IDLE)
> - reg |= PMSU_CONTROL_AND_CONFIG_L2_PWDDN;
> + reg |= PMSU_CTL_CFG_L2_PWDDN;
>
> /* request power down */
> - reg |= PMSU_CONTROL_AND_CONFIG_PWDDN_REQ;
> - writel(reg, pmsu_mp_base + PMSU_CONTROL_AND_CONFIG(hw_cpu));
> + reg |= PMSU_CTL_CFG_PWDDN_REQ;
> + writel(reg, pmsu_mp_base + PMSU_CTL_CFG(hw_cpu));
>
> if (flags & PMSU_PREPARE_SNOOP_DISABLE) {
> /* Disable snoop disable by HW - SW is taking care of it */
> @@ -347,17 +349,17 @@ void mvebu_v7_pmsu_idle_exit(void)
> if (pmsu_mp_base == NULL)
> return;
> /* cancel ask HW to power down the L2 Cache if possible */
> - reg = readl(pmsu_mp_base + PMSU_CONTROL_AND_CONFIG(hw_cpu));
> - reg &= ~PMSU_CONTROL_AND_CONFIG_L2_PWDDN;
> - writel(reg, pmsu_mp_base + PMSU_CONTROL_AND_CONFIG(hw_cpu));
> + reg = readl(pmsu_mp_base + PMSU_CTL_CFG(hw_cpu));
> + reg &= ~PMSU_CTL_CFG_L2_PWDDN;
> + writel(reg, pmsu_mp_base + PMSU_CTL_CFG(hw_cpu));
>
> /* cancel Enable wakeup events and mask interrupts */
> - reg = readl(pmsu_mp_base + PMSU_STATUS_AND_MASK(hw_cpu));
> - reg &= ~(PMSU_STATUS_AND_MASK_IRQ_WAKEUP | PMSU_STATUS_AND_MASK_FIQ_WAKEUP);
> - reg &= ~PMSU_STATUS_AND_MASK_CPU_IDLE_WAIT;
> - reg &= ~PMSU_STATUS_AND_MASK_SNP_Q_EMPTY_WAIT;
> - reg &= ~(PMSU_STATUS_AND_MASK_IRQ_MASK | PMSU_STATUS_AND_MASK_FIQ_MASK);
> - writel(reg, pmsu_mp_base + PMSU_STATUS_AND_MASK(hw_cpu));
> + reg = readl(pmsu_mp_base + PMSU_STATUS_MSK(hw_cpu));
> + reg &= ~(PMSU_STATUS_MSK_IRQ_WAKEUP | PMSU_STATUS_MSK_FIQ_WAKEUP);
> + reg &= ~PMSU_STATUS_MSK_CPU_IDLE_WAIT;
> + reg &= ~PMSU_STATUS_MSK_SNP_Q_EMPTY_WAIT;
Can these two be combined?
> + reg &= ~(PMSU_STATUS_MSK_IRQ_MASK | PMSU_STATUS_MSK_FIQ_MASK);
> + writel(reg, pmsu_mp_base + PMSU_STATUS_MSK(hw_cpu));
> }
>
> static int mvebu_v7_cpu_pm_notify(struct notifier_block *self,
> @@ -521,16 +523,16 @@ static void mvebu_pmsu_dfs_request_local(void *data)
> local_irq_save(flags);
>
> /* Prepare to enter idle */
> - reg = readl(pmsu_mp_base + PMSU_STATUS_AND_MASK(cpu));
> - reg |= PMSU_STATUS_AND_MASK_CPU_IDLE_WAIT |
> - PMSU_STATUS_AND_MASK_IRQ_MASK |
> - PMSU_STATUS_AND_MASK_FIQ_MASK;
> - writel(reg, pmsu_mp_base + PMSU_STATUS_AND_MASK(cpu));
> + reg = readl(pmsu_mp_base + PMSU_STATUS_MSK(cpu));
> + reg |= PMSU_STATUS_MSK_CPU_IDLE_WAIT |
> + PMSU_STATUS_MSK_IRQ_MASK |
> + PMSU_STATUS_MSK_FIQ_MASK;
Combine these?
Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists