linux-kernel - [PATCH] Logically DeadCode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 03 Jul 2015 04:52:31 +0000 (GMT)
From:	Rahul Jain <rahul.jain@...sung.com>
To:	davem@...emloft.net, johannes.berg@...el.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-wireless@...r.kernel.org
Cc:	Nitin Jhanwar <nitin.j@...sung.com>,
	"hemanshu.s@...sung.com" <hemanshu.s@...sung.com>,
	Amit Khatri <amit.khatri@...sung.com>
Subject: [PATCH] Logically DeadCode

hello,

From 0c34030166a150d6d9f1ab52e7bb40a5440a68c2 Mon Sep 17 00:00:00 2001
From: Rahul Jain <rahul.jain@...sung.com>
Date: Fri, 3 Jul 2015 10:19:12 +0530
Subject: [PATCH] Logically DeadCode

Signed-off-by: Rahul Jain <rahul.jain@...sung.com>
Signed-off-by: Amit Khatri <amit.khatri@...sung.com>
---
 net/wireless/util.c        | 3 ---
 net/wireless/wext-compat.c | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/net/wireless/util.c b/net/wireless/util.c
index baf7218..507e894 100644
--- a/net/wireless/util.c
+++ b/net/wireless/util.c
@@ -1009,9 +1009,6 @@ int cfg80211_change_iface(struct cfg80211_registered_device *rdev,
 		case NUM_NL80211_IFTYPES:
 			/* not happening */
 			break;
-		case NL80211_IFTYPE_P2P_DEVICE:
-			WARN_ON(1);
-			break;
 		}
 	}
 
diff --git a/net/wireless/wext-compat.c b/net/wireless/wext-compat.c
index fd68283..8de1b64 100644
--- a/net/wireless/wext-compat.c
+++ b/net/wireless/wext-compat.c
@@ -387,9 +387,6 @@ static int cfg80211_wext_siwretry(struct net_device *dev,
 		changed |= WIPHY_PARAM_RETRY_SHORT;
 	}
 
-	if (!changed)
-		return 0;
-
 	err = rdev_set_wiphy_params(rdev, changed);
 	if (err) {
 		wdev->wiphy->retry_short = oshort;
-- 
1.9.1