linux-kernel - Re: [PATCH v2 2/4] mfd: da9150: Update DT bindings for Fuel-Gauge support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150703151923.GB10500@x1>
Date:	Fri, 3 Jul 2015 16:19:23 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Adam Thomson <Adam.Thomson.Opensource@...semi.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, linux-pm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH v2 2/4] mfd: da9150: Update DT bindings for Fuel-Gauge
 support

On Fri, 26 Jun 2015, Adam Thomson wrote:

> Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>
> ---
>  Documentation/devicetree/bindings/mfd/da9150.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/da9150.txt b/Documentation/devicetree/bindings/mfd/da9150.txt
> index d0588ea..8bf1a20 100644
> --- a/Documentation/devicetree/bindings/mfd/da9150.txt
> +++ b/Documentation/devicetree/bindings/mfd/da9150.txt
> @@ -6,6 +6,7 @@ Device			 Description
>  ------			 -----------
>  da9150-gpadc		: General Purpose ADC
>  da9150-charger		: Battery Charger
> +da9150-fg		: Battery Fuel-Gauge
> 
>  ======
> 
> @@ -22,6 +23,7 @@ Required properties:
>  Sub-devices:
>  - da9150-gpadc: See Documentation/devicetree/bindings/iio/adc/da9150-gpadc.txt
>  - da9150-charger: See Documentation/devicetree/bindings/power/da9150-charger.txt
> +- da9150-fg: See Documentation/devicetree/bindings/power/da9150-fg.txt

Can you send a subsequent patch doing:

s-Documentation/devicetree/bindings/-../-
> 
> 

Superfluous '\n' here.

>  Example:
> @@ -40,4 +42,8 @@ Example:
>  		da9150-charger {
>  			...
>  		};
> +
> +		da9150-fg {
> +			...
> +		};

Perhaps a little content wouldn't go amiss here for quick reference.

Saves dipping in and out of the other binding files.

This patch is fine though:
  Acked-by: Lee Jones <lee.jones@...aro.org>

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/