linux-kernel - Re: [PATCH] sched_fair: test list head instead of list entry in throttle_cfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150703161037.GM25159@twins.programming.kicks-ass.net>
Date:	Fri, 3 Jul 2015 18:10:37 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Cong Wang <cwang@...pensource.com>
Subject: Re: [PATCH] sched_fair: test list head instead of list entry in
 throttle_cfs_rq()

On Fri, Jul 03, 2015 at 09:09:12AM -0700, Cong Wang wrote:
> On Wed, Jun 24, 2015 at 12:41 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> > According to the comments, we need to test if this is
> > the first throttled task, however, list_empty() tests on
> > the entry cfs_rq->throttled_list, not the head, this is wrong.
> >
> > This is a bug because we don't re-init the list entry after
> > removing it from the list, so list_empty() could return false
> > even if the list is really empty.
> >
> > Cc: Ingo Molnar <mingo@...hat.com>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> > Signed-off-by: Cong Wang <cwang@...pensource.com>
> 
> ping.
> 
> What's the status of this patch?

Queued, will likely hit tip after the merge window etc has settled.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/