linux-kernel - Re: [PATCH v2 3/4] ARM: mvebu: Allow using the GIC for wakeup in standby mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 03 Jul 2015 09:18:48 +0200
From:	Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
CC:	Jason Cooper <jason@...edaemon.net>, Andrew Lunn <andrew@...n.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
	linux-arm-kernel@...ts.infradead.org,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Boris BREZILLON <boris.brezillon@...e-electrons.com>,
	Lior Amsalem <alior@...vell.com>,
	Tawfik Bayouk <tawfik@...vell.com>,
	Nadav Haklai <nadavh@...vell.com>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] ARM: mvebu: Allow using the GIC for wakeup in
 standby mode

Hi Thomas,

On 01/07/2015 17:54, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
> 
> On Tue, 30 Jun 2015 19:18:59 +0200, Gregory CLEMENT wrote:
> 
>>  static void __init mvebu_init_irq(void)
>>  {
>> +	if (of_machine_is_compatible("marvell,armada375") ||
>> +	    of_machine_is_compatible("marvell,armada380") ||
>> +	    of_machine_is_compatible("marvell,armada390"))
> 
> What we really want to know is if we're using the GIC, so what about
> instead:
> 
> 	np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic");
> 	if (np)
> 		gic_set_irqchip_flags(IRQCHIP_SKIP_SET_WAKE |
> 				      IRQCHIP_MASK_ON_SUSPEND);
> 	of_node_put(np);
> 
> (Not even compile-tested).

Indeed it is better. I will make the change.

Thanks,

Gregory


> 
> Thanks,
> 
> Thomas
> 


-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/