linux-kernel - Re: [f2fs-dev] [PATCH 11/12] f2fs: add noextent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150704045735.GB15817@jaegeuk-mac02.hsd1.ca.comcast.net>
Date:	Fri, 3 Jul 2015 21:57:35 -0700
From:	Jaegeuk Kim <jaegeuk@...nel.org>
To:	Chao Yu <yuchaochina@...mail.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option

On Thu, Jul 02, 2015 at 08:35:34PM +0800, Chao Yu wrote:
> > -----Original Message-----
> > From: Jaegeuk Kim [mailto:jaegeuk@...nel.org]
> > Sent: Tuesday, June 30, 2015 2:40 AM
> > To: linux-kernel@...r.kernel.org; linux-fsdevel@...r.kernel.org;
> > linux-f2fs-devel@...ts.sourceforge.net
> > Cc: Jaegeuk Kim
> > Subject: [f2fs-dev] [PATCH 11/12] f2fs: add noextent_cache mount option
> > 
> > This patch adds noextent_cache mount option.
> 
> How about adding some descriptions in Documentation to help our user?
> 
> The other thing is we'd better to show 'noextent_cache' option when user
> lookups the mount options.
> 
> How about adding codes as below?
> if (test_opt(sbi, EXTENT_CACHE))
> 	seq_puts(seq, ",extent_cache");
> +else
> +	seq_puts(seq, ",noextent_cache");
> 

Agreed.

Thanks,

> > 
> > Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>
> 
> The other looks good to me, so please add:
> 
> Reviewed-by: Chao Yu <chao2.yu@...sung.com>
> 
> ------------------------------------------------------------------------------
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/