lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150704082623.GA7557@n2100.arm.linux.org.uk>
Date:	Sat, 4 Jul 2015 09:26:23 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Jisheng Zhang <jszhang@...vell.com>
Cc:	tglx@...utronix.de, jason@...edaemon.net,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 2/2] irqchip: dw-apb-ictl: add irq_set_affinity support

On Sat, Jul 04, 2015 at 01:19:30PM +0800, Jisheng Zhang wrote:
> On Marvell Berlin SoCs, the cpu's local timer is shutdown when the cpu
> goes to a deep idle state, then the timer framework will be notified to
> use a broadcast timer instead. The broadcast timer uses dw-apb-ictl as
> interrupt chip, this patch adds irq_set_affinity support so that the
> going to deep idle state cpu can set the interrupt affinity of the
> broadcast interrupt to avoid unnecessary wakeups and IPIs.

NAK to this patch.

The real question is - if CPU0 is the CPU going offline, why is it
still receiving _any_ interrupts - all interrupts should be migrated
off it, including the chained interrupts.

Sounds like there's a bug in the migration code which needs further
investigation, rather than hacking around the problem by introducing
lots of driver code.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ