linux-kernel - Re: [PATCH] thermal: consistently use int for temperatures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jul 2015 10:34:48 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	Linux PM list <linux-pm@...r.kernel.org>,
	Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <edubezval@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jean Delvare <jdelvare@...e.de>,
	Peter Feuerer <peter@...e.net>,
	Heiko Stuebner <heiko@...ech.de>,
	Lukasz Majewski <l.majewski@...sung.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Thierry Reding <thierry.reding@...il.com>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	platform-driver-x86@...r.kernel.org,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Guenter Roeck <linux@...ck-us.net>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Darren Hart <dvhart@...radead.org>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>,
	Linux-sh list <linux-sh@...r.kernel.org>
Subject: Re: [PATCH] thermal: consistently use int for temperatures

On Mon, Jul 6, 2015 at 9:19 AM, Sascha Hauer <s.hauer@...gutronix.de> wrote:
> The thermal code uses int, long and unsigned long for temperatures
> in different places.
>
> Using an unsigned type limits the thermal framework to positive
> temperatures without need. Also several drivers currently will report
> temperatures near UINT_MAX for temperatures below 0°C. This will probably
> immediately shut the machine down due to overtemperature if started below
> 0°C.
>
> 'long' is 64bit on several architectures. This is not needed since INT_MAX °mC
> is above the melting point of all known materials.
>
> Consistently use a plain 'int' for temperatures throughout the thermal code and
> the drivers. This only changes the places in the drivers where the temperature
> is passed around as pointer, when drivers internally use another type this is
> not changed.
>
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: Eduardo Valentin <edubezval@...il.com>
> Cc: linux-pm@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: Jean Delvare <jdelvare@...e.de>
> Cc: Peter Feuerer <peter@...e.net>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: Lukasz Majewski <l.majewski@...sung.com>
> Cc: Stephen Warren <swarren@...dotorg.org>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: linux-acpi@...r.kernel.org
> Cc: platform-driver-x86@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-omap@...r.kernel.org
> Cc: linux-samsung-soc@...r.kernel.org
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Rafael J. Wysocki <rjw@...ysocki.net>
> Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Cc: Darren Hart <dvhart@...radead.org>
> Cc: lm-sensors@...sensors.org

For rcar-thermal:
Acked-by: Geert Uytterhoeven <geert+renesas@...der.be>

> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index fe4e767..5d4ae7d 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -200,8 +200,7 @@ err_out_unlock:
>         return ret;
>  }
>
> -static int rcar_thermal_get_temp(struct thermal_zone_device *zone,
> -                                unsigned long *temp)
> +static int rcar_thermal_get_temp(struct thermal_zone_device *zone, int *temp)
>  {
>         struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone);
>
> @@ -235,7 +234,7 @@ static int rcar_thermal_get_trip_type(struct thermal_zone_device *zone,
>  }
>
>  static int rcar_thermal_get_trip_temp(struct thermal_zone_device *zone,
> -                                     int trip, unsigned long *temp)
> +                                     int trip, int *temp)
>  {
>         struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone);
>         struct device *dev = rcar_priv_to_dev(priv);
> @@ -299,7 +298,7 @@ static void _rcar_thermal_irq_ctrl(struct rcar_thermal_priv *priv, int enable)
>  static void rcar_thermal_work(struct work_struct *work)
>  {
>         struct rcar_thermal_priv *priv;
> -       unsigned long cctemp, nctemp;
> +       int cctemp, nctemp;
>
>         priv = container_of(work, struct rcar_thermal_priv, work.work);
>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/