linux-kernel - Re: [PATCH v3 2/2] irqchip: dw-apb-ictl: add irq_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1507061228060.3916@nanos>
Date:	Mon, 6 Jul 2015 12:30:01 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jisheng Zhang <jszhang@...vell.com>
cc:	jason@...edaemon.net, linux@....linux.org.uk,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 2/2] irqchip: dw-apb-ictl: add irq_set_affinity
 support

On Mon, 6 Jul 2015, Jisheng Zhang wrote:
> +static int dw_apb_ictl_set_affinity(struct irq_data *d,
> +				    const struct cpumask *mask_val,
> +				    bool force)
> +{
> +	struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d);
> +	struct dw_apb_ictl_priv *priv = gc->private;
> +	struct irq_chip *chip = irq_get_chip(priv->parent_irq);
> +	struct irq_data *data = irq_get_irq_data(priv->parent_irq);
> +
> +	if (chip && chip->irq_set_affinity)
> +		return chip->irq_set_affinity(data, mask_val, force);

This is wrong as it lacks proper locking of the parent irq. That needs
to be solved at the core code level in a clean way.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/