linux-kernel - Re: [PATCH] defines modified to match the 80-char rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3twtho503.fsf@t19.piap.pl>
Date:	Mon, 06 Jul 2015 14:16:44 +0200
From:	khalasa@...p.pl (Krzysztof Hałasa)
To:	Joe Perches <joe@...ches.com>
Cc:	Mario Bambagini <mario.bambagini@...il.com>,
	linux-kernel@...r.kernel.org,
	driverdev-devel@...uxdriverproject.org
Subject: Re: [PATCH] defines modified to match the 80-char rule

Joe Perches <joe@...ches.com> writes:

>> So, could we have the localized readability when it makes sense,
>> and the default rules when nothing else applies?
>
> Then the question becomes how local.

The answer seems easy to me: as much as it's needed to get the best
readability.

If that means 4 or 2 custom formatted lines, great. Why not?

It should be the maintainer's call anyway. It's (s)he who has to work
with the code in question most.

>> OTOH I think the 80 columns rule should go.
>
> I have no issue with that.
> There should be some limit though.

Sure, the max readability should set the limit. Though I would say one
shouldn't exceed maybe 132 chars (this is what old VT100 had, and this
is also supported on PC since some 8-bit XT-BUS VGA cards).

132 chars also allow for full 80-char "console output text" lines.
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/