linux-kernel - Re: [PATCH] staging: dgnc: Replace macro with flow control statement by a function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34054.1436189331@turing-police.cc.vt.edu>
Date:	Mon, 06 Jul 2015 09:28:51 -0400
From:	Valdis.Kletnieks@...edu
To:	Ravi Teja Darbha <ravi2j@...il.com>
Cc:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Arjun Krishna Babu <arjunkrishnababu96@...il.com>,
	devel@...verdev.osuosl.org, lidza.louina@...il.com,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH] staging: dgnc: Replace macro with flow control statement by a function

On Mon, 06 Jul 2015 18:50:12 +0530, Ravi Teja Darbha said:
> Why would you use a macro to avoid code duplication?

The macro does end up putting code in each place it's used.
However, the actual code is in one place rather than open-coded
in multiple places that can diverge over time (somebody patching 2 of
3 instances, and missing 1, for example).

Content of type "application/pgp-signature" skipped