linux-kernel - Re: [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <559AA02A.6060703@linaro.org>
Date:	Mon, 06 Jul 2015 17:35:06 +0200
From:	Eric Auger <eric.auger@...aro.org>
To:	Paolo Bonzini <pbonzini@...hat.com>, eric.auger@...com,
	linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
	kvm@...r.kernel.org, christoffer.dall@...aro.org,
	marc.zyngier@....com, alex.williamson@...hat.com,
	avi.kivity@...il.com, mtosatti@...hat.com, feng.wu@...el.com,
	joro@...tes.org, b.reynal@...tualopensystems.com
CC:	linux-kernel@...r.kernel.org, patches@...aro.org
Subject: Re: [RFC v2 3/6] irq: bypass: Extend skeleton for ARM forwarding
 control

Hi Paolo,
On 07/06/2015 02:27 PM, Paolo Bonzini wrote:
> 
> 
> On 06/07/2015 14:11, Eric Auger wrote:
>> diff --git a/kernel/irq/bypass.c b/kernel/irq/bypass.c
>> index 5d0f92b..efadbe5 100644
>> --- a/kernel/irq/bypass.c
>> +++ b/kernel/irq/bypass.c
>> @@ -19,6 +19,42 @@ static LIST_HEAD(producers);
>>  static LIST_HEAD(consumers);
>>  static DEFINE_MUTEX(lock);
>>  
>> +/* lock must be hold when calling connect */
> 
> If a lock must be held while callbacks are called, you have to document
> that producers and consumers must _not_ call back into the IRQ bypass
> manager.  (If they have to, you have to document explicitly "This
> function can be called from producer and consumer callbacks" whenever
> relevant).
OK Thanks

Eric
> 
>> +static void connect(struct irq_bypass_producer *prod,
>> +		    struct irq_bypass_consumer *cons)
>> +{
>> +	if (prod->stop)
>> +		prod->stop(prod);
>> +	if (cons->stop)
>> +		cons->stop(cons);
>> +	if (prod->add_consumer)
>> +		prod->add_consumer(prod, cons);
>> +	if (cons->add_producer)
>> +		cons->add_producer(cons, prod);
>> +	if (cons->resume)
>> +		cons->resume(cons);
>> +	if (prod->resume)
>> +		prod->resume(prod);
>> +}
>> +
>> +/* lock must be hold when calling disconnect */
>> +static void disconnect(struct irq_bypass_producer *prod,
>> +		       struct irq_bypass_consumer *cons)
>> +{
>> +	if (prod->stop)
>> +		prod->stop(prod);
>> +	if (cons->stop)
>> +		cons->stop(cons);
>> +	if (cons->del_producer)
>> +		cons->del_producer(cons, prod);
>> +	if (prod->del_consumer)
>> +		prod->del_consumer(prod, cons);
>> +	if (cons->resume)
>> +		cons->resume(cons);
>> +	if (prod->resume)
>> +		prod->resume(prod);
>> +}
>> +

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/