linux-kernel - Re: [PATCH v3 4/5] x86: pmc_atom: Add Cherrytrail PMC interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150706163950.GA22751@gmail.com>
Date:	Mon, 6 Jul 2015 18:39:50 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	"x86@...nel.org" <x86@...nel.org>,
	Aubrey Li <aubrey.li@...ux.intel.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
	"Kumar P, Mahesh" <mahesh.kumar.p@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH v3 4/5] x86: pmc_atom: Add Cherrytrail PMC interface


* Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Mon, Jul 6, 2015 at 6:50 PM, Ingo Molnar <mingo@...nel.org> wrote:
> >
> > * Thomas Gleixner <tglx@...utronix.de> wrote:
> >
> >> On Mon, 6 Jul 2015, Ingo Molnar wrote:
> >>
> >> > * Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> >> >
> >> > > The patch adds CHT PMC interface. This exposes all the South IP device power
> >> > > states and S0ix states for CHT. The bit map of FUNC_DIS and D3_STS_0 registers
> >> > > for SoCs are consistent. The D3_STS_1 and FUNC_DIS_2 registers, however, are
> >> > > not aligned. This is fixed by splitting a common mapping on per register basis.
> >> > >
> >> > > Signed-off-by: Kumar P Mahesh <mahesh.kumar.p@...el.com>
> >> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> >> >
> >> > That's a weird signoff sequence. I changed it to:
> >> >
> >> >  Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> >> >  Acked-by: Kumar P Mahesh <mahesh.kumar.p@...el.com>
> >>
> >> It might lack a From: Kumar ...
> >
> > Yeah, and got lost due to a rebase. Will change it to that, to preserve
> > authorship. Won't push it out before I hear back from Andy though.
> 
> To clarify: "It's based on the previous work done by Kumar P Mahesh."
> and we can remove SoB. It's quite far from the code initially taken
> from Kumar.
> 
> Would you like me to update the commit message accordingly?

Ok.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/