linux-kernel - Re: [PATCH] mfd: qcom-rpm: Add apq8064 QDSS clock resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150706203359.GA20663@sonymobile.com>
Date:	Mon, 6 Jul 2015 13:33:59 -0700
From:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
To:	"Ivan T. Ivanov" <ivan.ivanov@...aro.org>
CC:	Lee Jones <lee.jones@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH] mfd: qcom-rpm: Add apq8064 QDSS clock resource

On Mon 18 May 07:35 PDT 2015, Ivan T. Ivanov wrote:

> Qualcomm Debug Subsystem clock is used by CoreSight components.
> Add required definitions for it.
> 
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@...aro.org>

Sorry for the slow response Ivan.

> ---
>  drivers/mfd/qcom_rpm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index eceb34f..313aeae 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -149,6 +149,7 @@ static const struct qcom_rpm_resource apq8064_rpm_resource_table[] = {
>  	[QCOM_RPM_USB_OTG_SWITCH] =		{ 210, 125, 82, 1 },
>  	[QCOM_RPM_HDMI_SWITCH] =		{ 211, 126, 83, 1 },
>  	[QCOM_RPM_DDR_DMM] =			{ 212, 127, 84, 2 },
> +	[QCOM_RPM_QDSS_CLK] =			{ 214, 129, 7, 1 },

214, 7 and 1 are correct. But as far as I can see in my tables the QDSS
clock doesn't have any status (129 seems to be EBI1_CH0_RANGE).

The status_id was originally included because I was reading it and I saw
that Srinivas has some code that reads it, but unless it shows to be
useful we should probably just drop that entire column...

But for now please mark it as -1 or so and we can have a chat with
Srinivas on dropping the column later.

>  	[QCOM_RPM_VDDMIN_GPIO] =		{ 215, 131, 89, 1 },
>  };
> 

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/