| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150706225258.GC32140@dtor-ws> Date: Mon, 6 Jul 2015 15:52:58 -0700 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Martin Kepplinger <martink@...teo.de> Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] input: misc: bma150: use sign_extend32() for sign extending On Fri, Jul 03, 2015 at 01:13:01AM +0200, Martin Kepplinger wrote: > Despite it's name, sign_extend32() is used for 16 bit values aswell. > > Signed-off-by: Martin Kepplinger <martink@...teo.de> Applied, thank you. > --- > drivers/input/misc/bma150.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/misc/bma150.c b/drivers/input/misc/bma150.c > index b36831c..c278049 100644 > --- a/drivers/input/misc/bma150.c > +++ b/drivers/input/misc/bma150.c > @@ -333,10 +333,9 @@ static void bma150_report_xyz(struct bma150_data *bma150) > y = ((0xc0 & data[2]) >> 6) | (data[3] << 2); > z = ((0xc0 & data[4]) >> 6) | (data[5] << 2); > > - /* sign extension */ > - x = (s16) (x << 6) >> 6; > - y = (s16) (y << 6) >> 6; > - z = (s16) (z << 6) >> 6; > + x = sign_extend32(x, 9); > + y = sign_extend32(y, 9); > + z = sign_extend32(z, 9); > > input_report_abs(bma150->input, ABS_X, x); > input_report_abs(bma150->input, ABS_Y, y); > -- > 2.1.4 > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists