linux-kernel - Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Jul 2015 22:01:11 -0700
From:	Joe Perches <joe@...ches.com>
To:	Greg KH <greg@...ah.com>
Cc:	Vasiliy Korchagin <vasiliy.korchagin@...il.com>,
	oleg.drokin@...el.com, devel@...verdev.osuosl.org,
	andreas.dilger@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue
 in uuid.c

On Mon, 2015-07-06 at 19:36 -0700, Greg KH wrote:
> On Fri, Jun 26, 2015 at 11:04:49PM -0700, Joe Perches wrote:
> > On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote:
[]
> > >     Here is another version with macro expansion. Inline function expansion doesn't
> > >     seem like a good idea to me as it would make things overcomplicated.
> > 
> > It looks like it'd be simpler to use vsprintf extension %pU
[]
> > diff --git a/drivers/staging/lustre/lustre/obdclass/uuid.c b/drivers/staging/lustre/lustre/obdclass/uuid.c
[]
> > +	sprintf(out->uuid, "%pU", uu);
> >  }
> >  EXPORT_SYMBOL(class_uuid_unparse);
> 
> I agree, much better, can you resend this in a form I can apply?

Vasiliy, you started this, can you submit this
under your name please?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/